[ModelicaSystem] split simulate() into two methods #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(1) create ModelicasystemCmd instance - simulate_cmd() (2) run it - simulate()
syntron
force-pushed
the
ModelicaSystem_simulate
branch
from
b57bd0c to
3ee7f7d
Compare
adeas31
reviewed
Jul 1, 2025
|
@adeas31 splitting simulate into two parts allows to define the command to run the executable without running it. Thus, several runs can be defined and later be executed using the same executable. See PR #312; it also contains an example as unittest where this is used. The example runs a DoE including structural and non-structural parameters. While any combination of non-structural parameters can be run using the same executable, any change of a structural parameter needs a rebuild of the executable. The new class - ModelicaSystemDoE - prepares all runs of the DoE (builing the model executable if needed) and then executes them in parallel. This also relates to issue #230 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ModelicaSystem] split simulate() into two methods
(1) create ModelicasystemCmd instance - simulate_cmd()
(2) run it - simulate()
reason: